----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22812/#review46281 -----------------------------------------------------------
Ship it! Ship It! - Gordon Sim On June 20, 2014, 12:56 p.m., Pavel Moravec wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22812/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 12:56 p.m.) > > > Review request for qpid, Ernie Allen, Justin Ross, and Kim van der Riet. > > > Bugs: QPID-5835 > https://issues.apache.org/jira/browse/QPID-5835 > > > Repository: qpid > > > Description > ------- > > Simple extension of [Exchange|Queue]::[encode|restore] by adding boolean as > int8_t at the end of the buffer. Should be backwards compatible. > > There is one question how queue node with auto-delete:True _and_ auto-delete > timeout set should be recovered: should be the timer ticking or not? > Currently implemented option is the timer is not running: as we dont know if > the queue had a consumer before restart, let be conservative and think it > hadn't. > > But this might cause queue leak in scenarios like "create auto-delete queue > with timeout, subscribe to it, restart broker, dont re-subscribe there" > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/Exchange.cpp 1603448 > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1603448 > > Diff: https://reviews.apache.org/r/22812/diff/ > > > Testing > ------- > > Automated tests passed, manual tests show JIRA is fixed by the patch. > > > Thanks, > > Pavel Moravec > >
