[ 
https://issues.apache.org/jira/browse/QPID-5857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy reassigned QPID-5857:
--------------------------------

    Assignee: Keith Wall  (was: Alex Rudyy)

Keith,
Could you please review the change I made to improve reliability of test 
ConsumerLoggingTest.testSubscriptionCreateQueue?

Test was collecting subscription operational logs after appearance of 
subscription creation log entry. IMHO, it makes possible a log collection 
before subscription is closed. Thus, not all logs can be collected and test 
would fail. Log collection after appearance of subscription closing log entry 
should strengthen the test and make it more reliable

> [Java Broker] Test ConsumerLoggingTest.testSubscriptionCreateQueue 
> sporadically fails
> -------------------------------------------------------------------------------------
>
>                 Key: QPID-5857
>                 URL: https://issues.apache.org/jira/browse/QPID-5857
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Tests
>            Reporter: Alex Rudyy
>            Assignee: Keith Wall
>             Fix For: 0.29
>
>
> Test ConsumerLoggingTest.testSubscriptionCreateQueue sporadically fails:
> {noformat}
> testSubscriptionCreateQueueBrowser(org.apache.qpid.server.logging.ConsumerLoggingTest)
>   Time elapsed: 0.044 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Result set larger than expected. 
> expected:<5> but was:<2>
>       at junit.framework.Assert.fail(Assert.java:57)
>       at junit.framework.Assert.failNotEquals(Assert.java:329)
>       at junit.framework.Assert.assertEquals(Assert.java:78)
>       at junit.framework.Assert.assertEquals(Assert.java:234)
>       at junit.framework.TestCase.assertEquals(TestCase.java:401)
>       at 
> org.apache.qpid.server.logging.ConsumerLoggingTest.testSubscriptionCreateQueueBrowser(ConsumerLoggingTest.java:181)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to