----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23138/ -----------------------------------------------------------
Review request for qpid, Alan Conway and Gordon Sim. Repository: qpid Description ------- Big difference this time is -- I understand now why I can't hide MessageTransfer::computeRequiredCredit, so I didn't. But there is a problem in that code elsewhere sometimes calls getRequiredCredit before computeRequiredCredit has been called. I would like to solve that problem separately, so for now I have just put a sternly-worded TODO in get(). Diffs ----- trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1605815 trunk/qpid/cpp/src/qpid/broker/amqp_0_10/MessageTransfer.cpp 1605815 trunk/qpid/cpp/src/qpid/framing/FrameSet.h 1605815 Diff: https://reviews.apache.org/r/23138/diff/ Testing ------- Re-ran my tests for average latency for message of size 2048, in range from 10000 to 20000 messages per second. Same performance as before. In trunk code, this patch only helps a little, but it does no harm. ( It does more good in the 0.22 version. ) Thanks, mick goulish
