----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23122/#review47208 -----------------------------------------------------------
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/object/object.c <https://reviews.apache.org/r/23122/#comment82848> I think strictly speaking we should copy these pointers out and move the decrefs to the end of this function. It is hypothetically possible that one or both of the decrefs could trigger a finalize which in turn re-enters this code by deleting from the map. To deal with that case we probably want the hashtable data structures to be in a fully modified and in a consistent state before calling decref. - Rafael Schloming On July 2, 2014, 4:18 p.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23122/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 4:18 p.m.) > > > Review request for qpid and Rafael Schloming. > > > Bugs: PROTON-617 > https://issues.apache.org/jira/browse/PROTON-617 > > > Repository: qpid > > > Description > ------- > > The proposed fix tests for the case of being the first link in a multipart > chain and copies the second entry over top and makes the old location of the > second entry available for reuse. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/object/object.c > 1607407 > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/tests/object.c > 1607407 > > Diff: https://reviews.apache.org/r/23122/diff/ > > > Testing > ------- > > > Thanks, > > Cliff Jansen > >
