----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23381/#review47556 -----------------------------------------------------------
Ship it! Thanks, Chuck! Sorry, I had not even noticed that I broke things! - Gordon Sim On July 9, 2014, 10:03 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23381/ > ----------------------------------------------------------- > > (Updated July 9, 2014, 10:03 p.m.) > > > Review request for qpid and Gordon Sim. > > > Bugs: QPID-5886 > https://issues.apache.org/jira/browse/QPID-5886 > > > Repository: qpid > > > Description > ------- > > This patch separates the CompletionImpl constructors into a new cpp file and > explicitly instantiates Handle<CompletionImpl> for linking on Windows. > > > Diffs > ----- > > trunk/qpid/cpp/src/CMakeLists.txt 1608612 > trunk/qpid/cpp/src/qpid/client/Completion.cpp 1608612 > trunk/qpid/cpp/src/qpid/client/CompletionImpl.h 1608612 > trunk/qpid/cpp/src/qpid/client/CompletionImpl.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/23381/diff/ > > > Testing > ------- > > > Thanks, > > Chug Rolke > >
