----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23811/ -----------------------------------------------------------
Review request for qpid and Kenneth Giusti. Repository: qpid Description ------- qpid-route is unable to create routes involving older c++ brokers. The management api for link.bridge() has changed. Formerly it took 10 arguments. Currently it takes an additional credit argument. If an older broker is involved, qpid-route fails with an "Incorrect number of arguments" error. This patch implements Ken's proposed solution of attempting the link.bridge() call with the credit argument. If that fails with the "Incorrect number of arguments" error, then attempt the link.bridge() call without the credit argument. Diffs ----- /trunk/qpid/tools/src/py/qpid-route 1612587 Diff: https://reviews.apache.org/r/23811/diff/ Testing ------- mrg30 is running 0.22 mrg41 is running 0.18 ./qpid-route queue add mrg30.lab.bos.redhat.com mrg41.lab.bos.redhat.com amq.fanout fed.q ./qpid-route route list mrg30.lab.bos.redhat.com mrg30.lab.bos.redhat.com:5672 mrg41.lab.bos.redhat.com:5672 amq.fanout ./qpid-route queue add mrg41.lab.bos.redhat.com mrg30.lab.bos.redhat.com amq.fanout fed.q1 ./qpid-route route list mrg41.lab.bos.redhat.com mrg41.lab.bos.redhat.com:5672 mrg30.lab.bos.redhat.com:5672 amq.fanout Also, I verified that if an exception other than "Incorrect number of arguments" is raised, it is re-raised properly. Thanks, Ernie Allen
