-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23977/
-----------------------------------------------------------
Review request for qpid, Gordon Sim, Kim van der Riet, and Ted Ross.
Bugs: QPID-5929
https://issues.apache.org/jira/browse/QPID-5929
Repository: qpid
Description
-------
Apart from marking deprecated QMF fields with description "Deprecated" in
management-schema.xml (just to document this fact anywhere), I suggest
simplifying the code by removing some bits relevant to the deprecated fields.
In particular:
- remove some Ftd related methods (dead code)
- don't call session's set_detachedLifespan(0) as that is already the default
- don't call connection's set_shadow(false) as that is already the default
- userProxyAuth is in fact deprecated; the only place where it can have value
is in cpp/src/qpid/broker/amqp/ManagedConnection.cpp, line:
connection = _qmf::Connection::shared_ptr(new _qmf::Connection(agent, this,
parent, id, !brokerInitiated, brokerInitiated, "AMQP 1.0"));
(the last but not least parameter). But I see it use-less to have userProxyAuth
= !incoming property (or does it have some sense? then amqp_0_10 should set it
as well, now it sets false everytime).
In either case, userProxyAuth property from nonQMF connection class can be
removed - it's everytime set to false. Propagating its value, isUserProxyAuth()
equals to isFederationLink() method and can be replaced.
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/Queue.h 1613795
/trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1613795
/trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1613795
/trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1613795
/trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.cpp 1613795
/trunk/qpid/cpp/src/qpid/broker/amqp/ManagedSession.cpp 1613795
/trunk/qpid/cpp/src/qpid/broker/amqp_0_10/Connection.h 1613795
/trunk/qpid/cpp/src/qpid/broker/amqp_0_10/Connection.cpp 1613795
/trunk/qpid/cpp/src/qpid/broker/management-schema.xml 1613795
/trunk/qpid/cpp/src/qpid/legacystore/management-schema.xml 1613795
/trunk/qpid/cpp/src/qpid/linearstore/management-schema.xml 1613795
Diff: https://reviews.apache.org/r/23977/diff/
Testing
-------
automated tests passed
Thanks,
Pavel Moravec
