[ 
https://issues.apache.org/jira/browse/QPID-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080921#comment-14080921
 ] 

Keith Wall commented on QPID-5937:
----------------------------------

Hi Rob, 

Could of minor comments:

# Formal parameter naming into new method:
ConfiguredObject#getContextKeys(final boolean includeSystem);
AbstractConfiguredObject#getContextKeys(final boolean excludeSystem)

# RestServlet#getBooleanParameterFromRequest   parseBoolean cannot throw a NFE 
and is null safe.



> [Java Broker] Add parameters to REST servlet to allow return of actual vs. 
> effective attribute values
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-5937
>                 URL: https://issues.apache.org/jira/browse/QPID-5937
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>             Fix For: 0.29
>
>
> Add parameters to the REST servlet to allow control over the retrieval of the 
> effective values of parameters, versus the "actual" values (which may need 
> interpolation or be inherited).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to