----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24851/#review51175 -----------------------------------------------------------
What was the reproducer to expose this problem? Did it happen rarely or on demand? I'd be happy to try a reproducer and again with the fixed code to verify. - Chug Rolke On Aug. 19, 2014, 3:01 p.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24851/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2014, 3:01 p.m.) > > > Review request for qpid, Andrew Stitcher and Steve Huston. > > > Bugs: QPID-5033 > https://issues.apache.org/jira/browse/QPID-5033 > > > Repository: qpid > > > Description > ------- > > This patch isolates the logic of using the correct amount of buffers and not > hanging onto an unread buffer unless it actually is one. It has been heavily > tested on Linux and only been lightly tested on Windows. See patch #2 for > the better windows version. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/AsynchIO.h > 1618723 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp > 1618723 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/AsynchIO.h > PRE-CREATION > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/AsynchIO.cpp > 1618723 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/SslAsynchIO.cpp > 1618723 > > Diff: https://reviews.apache.org/r/24851/diff/ > > > Testing > ------- > > > Thanks, > > Cliff Jansen > >
