----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25026/#review51404 -----------------------------------------------------------
I give tihs a conditional "Ship It". None of my Windows environments have Swig installed so they don't test this patch any more than to say that the patch doesn't break anything. - Chug Rolke On Aug. 25, 2014, 2:53 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25026/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2014, 2:53 p.m.) > > > Review request for qpid, Andrew Stitcher, Chug Rolke, and Steve Huston. > > > Repository: qpid > > > Description > ------- > > FindPythonLibs on older versions of cmake (observed on cmake-2.6.4-5.el5.4) > sometimes finds the static archive library (.a) before the shared object > library (.so) This is almost never what you want. Newer > versions (e.g. cmake-2.8.12.2-2.fc20.x86_64) explicitly look for the .so first > and look for the .a library second. > > This workaround fixes the problem as follows: > - It is a no-op except on Unix platforms that use the .so prefix. > - On those platforms it does a search for .so only first. > - Finally we do a default search for other platforms (or if .so was not found) > > > Diffs > ----- > > trunk/qpid/cpp/bindings/CMakeLists.txt 1619877 > > Diff: https://reviews.apache.org/r/25026/diff/ > > > Testing > ------- > > Tested on RHEL5 (old cmake) and Fedora 20 (new cmake) Needs testing on > windows. > > > Thanks, > > Alan Conway > >
