[
https://issues.apache.org/jira/browse/QPID-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146918#comment-14146918
]
Keith Wall commented on QPID-6114:
----------------------------------
Couple of comments on this commit:
# I think this change makes the overridden #getAttribute methods in ACO
subclasses redundant. Perhaps ACO#getAttribute should be made final too?
# Why is _state no longer protected by a memory barrier?
# Not directly related to this commit, but I wonder if BDBHAReplicaVirtualHost
should implement validateChange to reject all attempted mutations?
> Migrate the State member variable to AbstractConfiguredObject class
> -------------------------------------------------------------------
>
> Key: QPID-6114
> URL: https://issues.apache.org/jira/browse/QPID-6114
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Andrew MacBean
> Assignee: Alex Rudyy
> Fix For: 0.31
>
>
> As all ACOs should have State, this is the most sensible place for this and
> its getter and setter to live just now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
