----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26075/#review54666 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On Sept. 26, 2014, 6:46 a.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26075/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2014, 6:46 a.m.) > > > Review request for qpid. > > > Bugs: PROTON-668 > https://issues.apache.org/jira/browse/PROTON-668 > > > Repository: qpid > > > Description > ------- > > This describes my best guess of balancing convenience for the developer > versus performance. Ultimately, with the exception of stickiness between > completion ports and sockets, which prevents moving a socket between or out > of a pn_io_t, any Posix behavior can probably be mimicked in Windows, but at > a performance penalty. > > With these restrictions, third party event loops are supported. Proton event > loops can also accommodate external non-sockets if that is useful (if > dispensed with, that makes Windows code easier). Multi-threaded IO as > currently used in Dispatch is also supported. > > It is worth noting Bozo's points that the interface doesn't always make sense > for multithreaded ops: pn_io_error() and pn_io_wouldblock(). > > Finally, it should be noted that the Windows code has some way to go to > satisfy the above, but understanding the intended supported capabilities > needs to come first. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/io.h > 1627716 > > Diff: https://reviews.apache.org/r/26075/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Cliff Jansen > >
