----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26865/#review57131 -----------------------------------------------------------
Ship it! Compiles 2008/x86 and 2013/x64 but untested to see if it actually denies connection as claimed. - Chug Rolke On Oct. 17, 2014, 7:26 a.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26865/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 7:26 a.m.) > > > Review request for qpid, Chug Rolke and Kenneth Giusti. > > > Bugs: PROTON-719 > https://issues.apache.org/jira/browse/PROTON-719 > > > Repository: qpid > > > Description > ------- > > Do not allow ssl v3 Proton connections even if user has set registry entries > forcing SChannel to request/accept ssl v3. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/windows/schannel.c > 1632478 > > Diff: https://reviews.apache.org/r/26865/diff/ > > > Testing > ------- > > Windoww XP -> Windows 8.1 > 32/64 bit > VS2008->VS2013 > > VS2008 failed first attempt for fix > > > Thanks, > > Cliff Jansen > >
