-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27032/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 7:52 a.m.)
Review request for qpid, Ernie Allen, Kenneth Giusti, and Ted Ross.
Changes
-------
Simplified the patch per Ken's comment.
Bugs: QPID-6177
https://issues.apache.org/jira/browse/QPID-6177
Repository: qpid
Description
-------
Simple patch that overwrites default empty brokerConnectionFailed method raised
when connection fails. It makes sense to react only when connecting for the
first time.
Changes in package imports are irrelevant to this JIRA - I had to do the change
to let qpid-tool to start working on trunk (?).
As the logic of QMF console is to retry failed connections, I suggest just
raising some warning than directly stopping qpid-tool.
Diffs (updated)
-----
trunk/qpid/tools/src/py/qpid-tool 1633165
Diff: https://reviews.apache.org/r/27032/diff/
Testing
-------
Testing with invalid hostname:
$ ./tools/src/py/qpid-tool invalidHost
Management Tool for QPID
qpid: Failed to connect: [Errno -2] Name or service not known
Testing with no SASL mech in common:
$ ./tools/src/py/qpid-tool
Management Tool for QPID
qpid: Failed to connect: (None, 'sasl negotiation failed: no mechanism agreed')
Thanks,
Pavel Moravec
