On 11/17/2014 08:14 PM, Andrew Stitcher wrote:
As we currently don't have reviewboard set up for Qpid Proton (since the
git migration).
I've posted a pull request against the Github Apache proton mirror to
get review feedback for my IO layer refactoring.
https://github.com/apache/qpid-proton/pull/1
Please give it some attention, I know that Rafi would like this change
to go in quickly as some important changes are queued up behind it.
I'm confused around the intention with regards to backward
compatibility. There seem to be changes that would break this, which is
entirely fine, but then old functions are retained but deprecated. If
the contract is indeed broken in some way, I think it would be better
not to retain functions that are no longer intended for use.
In a similar vein for the python binding, for the Transport constructor,
I think it would be better to insist that either a c transport object or
a mode is provided, rather than defaulting to a client.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
