I commented on the pull request already, but for good measure I'll add my "Ship It!" here also.
BTW, I should say despite my prior grumbles on a few of the API choices, the change significantly improves a number of brittle areas and I'm very happy to see this kind of work being done. --Rafael On Wed, Nov 19, 2014 at 6:01 PM, Andrew Stitcher <[email protected]> wrote: > On Mon, 2014-11-17 at 15:14 -0500, Andrew Stitcher wrote: > > As we currently don't have reviewboard set up for Qpid Proton (since the > > git migration). > > > > I've posted a pull request against the Github Apache proton mirror to > > get review feedback for my IO layer refactoring. > > > > https://github.com/apache/qpid-proton/pull/1 > > I've respun this change after discussion with Rafi and Gordon: > > https://github.com/apache/qpid-proton/pull/3 > > As before comments (here, or perhaps on the pull request itself) are > welcome. > > Andrew > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
