----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28770/ -----------------------------------------------------------
(Updated Dec. 9, 2014, 11:56 a.m.) Review request for qpid and Rafael Schloming. Changes ------- Added a README for the examples. Altered the manner in which the uniform event interface is implemented: (1) tidied up the extra properties on Event by adding connection and session properties to delivery, (2) split out a minial EventBase from the Event class, (3) altered the collector such that if the context popped extends this base class, it is treated as an Event itself. This allows applications to define their own event classes, which I use to allow an extended event that offers the same uniform interface as the core engine events but other implementations are equally possible. Repository: qpid-proton-git Description ------- These are the current reactive examples using the engine API, that I have been evolving on the examples branch, alog with the utility code they depend on. I still need to evolve/rationalise the examples themselves as well as the utility code, but I believe it would be beneficial to all to do this from the master branch. Diffs (updated) ----- examples/engine/py/README PRE-CREATION examples/engine/py/abstract_server.py PRE-CREATION examples/engine/py/client.py PRE-CREATION examples/engine/py/client_http.py PRE-CREATION examples/engine/py/common.py PRE-CREATION examples/engine/py/db_common.py PRE-CREATION examples/engine/py/db_ctrl.py PRE-CREATION examples/engine/py/db_recv.py PRE-CREATION examples/engine/py/db_send.py PRE-CREATION examples/engine/py/helloworld.py PRE-CREATION examples/engine/py/helloworld_blocking.py PRE-CREATION examples/engine/py/helloworld_direct.py PRE-CREATION examples/engine/py/helloworld_direct_tornado.py PRE-CREATION examples/engine/py/helloworld_tornado.py PRE-CREATION examples/engine/py/proton_server.py PRE-CREATION examples/engine/py/proton_tornado.py PRE-CREATION examples/engine/py/recurring_timer.py PRE-CREATION examples/engine/py/recurring_timer_tornado.py PRE-CREATION examples/engine/py/selected_recv.py PRE-CREATION examples/engine/py/server.py PRE-CREATION examples/engine/py/server_tx.py PRE-CREATION examples/engine/py/simple_recv.py PRE-CREATION examples/engine/py/simple_send.py PRE-CREATION examples/engine/py/sync_client.py PRE-CREATION examples/engine/py/tx_recv.py PRE-CREATION examples/engine/py/tx_recv_interactive.py PRE-CREATION examples/engine/py/tx_send.py PRE-CREATION examples/engine/py/tx_send_sync.py PRE-CREATION proton-c/bindings/python/CMakeLists.txt 6be421e237f86f2aa99c23ffbc08af821b5c8438 proton-c/bindings/python/proton/__init__.py fce3255bfce440dcae57457d259147a4ced8216e proton-c/bindings/python/proton/handlers.py PRE-CREATION proton-c/bindings/python/proton/reactors.py PRE-CREATION proton-c/bindings/python/proton/utils.py PRE-CREATION Diff: https://reviews.apache.org/r/28770/diff/ Testing ------- All examples have been tested, note that the transactional examples require a couple of extra proton-c patches (available on respective JIRAs) in order to run correctly. Thanks, Gordon Sim
