-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29584/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher and Kenneth Giusti.
Repository: qpid
Description
-------
Python qpid.messaging fails when the username or password is unicode in the
connection options.
Reproducer from Brian Bouterse:
>>> from qpid.messaging.endpoints import Connection
>>> opts =
{'username': u'guest', 'sasl_mechanisms': 'ANONYMOUS', 'host': '127.0.0.1',
'timeout': 4, 'password': '', 'port': 5672, 'transport': 'tcp'}
>>> Connection.establish(**opts)
This results in an exception
File "/usr/lib/python2.7/site-packages/qpid/codec010.py", line 401, in write
self.encoded += s
UnicodeDecodeError: 'ascii' codec can't decode byte 0x92 in position 7: ordinal
not in range(128)File "/usr/lib/python2.7/site-packages/qpid/codec010.py", line
401, in write
self.encoded += s
UnicodeDecodeError: 'ascii' codec can't decode byte 0x92 in position 7: ordinal
not in range(128)
Diffs
-----
trunk/qpid/python/qpid/codec010.py 1640973
trunk/qpid/python/qpid/sasl.py 1640973
Diff: https://reviews.apache.org/r/29584/diff/
Testing
-------
Tested the supplied reproducer on F21 and RHEL 6.4.
Also ran a "make test"
Thanks,
Ernie Allen
