----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29821/#review67710 -----------------------------------------------------------
trunk/qpid/cpp/examples/messaging/server.cpp <https://reviews.apache.org/r/29821/#comment111792> It's a shame it needs to be as ugly as this. I'd actually thought content-object would be interpreted as a utf8 string on the 1.0 path if no encoding was specified, but I see that is not yet the case. Would also be nice to have a simpler way of creating a variant with encoding. However I'm fine with your change as is, since these are really wider improvements. - Gordon Sim On Jan. 12, 2015, 9:30 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29821/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 9:30 p.m.) > > > Review request for qpid and Gordon Sim. > > > Bugs: QPID-6308 > https://issues.apache.org/jira/browse/QPID-6308 > > > Repository: qpid > > > Description > ------- > > The example as-is sends strings as vbin8 0xA0 binary encoding only, > regardless of the request string format. This patch preserves the request > string encoding scheme and uses it in the response. > > > Diffs > ----- > > trunk/qpid/cpp/examples/messaging/server.cpp 1650356 > > Diff: https://reviews.apache.org/r/29821/diff/ > > > Testing > ------- > > Tested against Qpid C++ client and Amqp.Net Lite (utf8-only) clients. > > > Thanks, > > Chug Rolke > >
