----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30484/ -----------------------------------------------------------
Review request for qpid and Fraser Adams. Repository: qpid-proton-git Description ------- This patch modifies the wrapper for pn_data_format to pass a stack allocated pointer to setValue rather than using the size directly. I don't fully understand the details of emscripten, but my theory is that previously the call to setValue was treating the size value (initially 1024) as a pointer and corrupting the heap at that location. I'm guessing at higher optimization levels, (or with different compiler versions) whatever happens to be sitting at address 1024 is not as critical and so the memory corruption doesn't have the same impact. I'm mostly guessing at a few details of the emscripten API here, so I'd appreciate a thourough review. Diffs ----- proton-c/bindings/javascript/data.js 018c5fb Diff: https://reviews.apache.org/r/30484/diff/ Testing ------- With this change, the send.js/recv.js examples work fine in Debug mode. The javascript tests also work fine. Thanks, Rafael Schloming
