----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30206/#review70569 -----------------------------------------------------------
Ship it! Ship It! - Gordon Sim On Jan. 27, 2015, 1:28 a.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30206/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 1:28 a.m.) > > > Review request for qpid and Gordon Sim. > > > Bugs: QPID-5538 > https://issues.apache.org/jira/browse/QPID-5538 > > > Repository: qpid > > > Description > ------- > > Minor tweak to Gordon's original patch > > > Diffs > ----- > > trunk/qpid/cpp/src/qpid/broker/amqp/Connection.h 1653631 > trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1653631 > trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.h 1653631 > trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp 1653631 > trunk/qpid/cpp/src/qpid/messaging/amqp/DriverImpl.h 1653631 > trunk/qpid/cpp/src/qpid/messaging/amqp/DriverImpl.cpp 1653631 > trunk/qpid/cpp/src/qpid/messaging/amqp/Transport.h 1653631 > trunk/qpid/cpp/src/tests/CMakeLists.txt 1653631 > trunk/qpid/cpp/src/tests/idle_timeout_tests.py PRE-CREATION > > Diff: https://reviews.apache.org/r/30206/diff/ > > > Testing > ------- > > Unit tests pass. Manually SIGSTOP the broker and the client to trigger the > timeout. > > > Thanks, > > Kenneth Giusti > >
