[
https://issues.apache.org/jira/browse/QPID-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316576#comment-14316576
]
Robbie Gemmell commented on QPID-6381:
--------------------------------------
The initial commit fixes things fro detaches that specify closed=true, and
keeps working for when detaching with closed=false and UNSETTLED_STATE
durability.
There is a bit nested further down the method where it deletes the backing
queue if attached to an exchange and using CONFIGURATION or UNSETTLED_STATE
durability. If I update the new client to use CONFIGURATION durability for its
DurableSubscription links (an option we said we would put in the mapping doc)
then things go awry again and it will delete the backing queue even when
detaching with closed=false. Should the initial if statement be updated to also
exclude CONFIGURATION durability as well, that way the nested if will only run
for those durabilities when closed=true?
> [Java Broker] [AMQP 1.0] the 'closed' field is ignored when detaching
> ---------------------------------------------------------------------
>
> Key: QPID-6381
> URL: https://issues.apache.org/jira/browse/QPID-6381
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.31
> Reporter: Robbie Gemmell
> Assignee: Rob Godfrey
> Fix For: 0.31
>
>
> The broker does not currently inspect the closed flag of the Detach when
> deciding whether to close detaching consumer links, and instead seems to base
> its action on the terminus durability.
> E.g in SendingLink_1_0.remoteDetached(LinkEndpoint, Detach), it inspects the
> source terminus-durability and closes [almost] everything that is not
> specifying UNSETTLED_STATE durability:
> {noformat}
> //TODO
> // if not durable or close
> if(!TerminusDurability.UNSETTLED_STATE.equals(_durability))
> {
> {noformat}
> This is presumably the reason that QPID-6380 does not result in removal of
> the DurableSubscription backing queue when 'closing' a JMS durable
> TopicSubscriber from the 'existing' AMQP 1.0 JMS client, as it uses
> UNSETTLED_STATE durability on those links.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
