----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31121/#review73190 -----------------------------------------------------------
trunk/python/qpid_dispatch/management/qdrouter.json <https://reviews.apache.org/r/31121/#comment119419> Based on the code this should be an "integer", you should add the units (seconds?) to the description. We could also add "double" to our types (1 line in schema.py) and do the python-like thing where times are floating-point seconds since epoch. That would let us do finer-grained timestamps in future if need be, but it does make equality-testing of stringified values trickier. trunk/python/qpid_dispatch_internal/router/node.py <https://reviews.apache.org/r/31121/#comment119423> On the current trunk this is: def refresh_entity(self, attributes): """Refresh management attributes""" attributes.update({ "routerId": self.id, "instance": self.instance, # Boot number, integer "linkState": [ls for ls in self.link_state.peers], # List of neighbour nodes "nextHop": self.next_hop_router and self.next_hop_router.id, "validOrigins": self.valid_origins, "address": Address.topological(self.id, area=self.parent.container.area), "routerLink": self.peer_link_id }) so your topo change line would be added to that. - Alan Conway On Feb. 17, 2015, 5:32 p.m., michael goulish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31121/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 5:32 p.m.) > > > Review request for qpid, Alan Conway and Ted Ross. > > > Repository: qpid-dispatch > > > Description > ------- > > DISPATCH-113 : expose NodeTracker::last_topology_change to management > > > Diffs > ----- > > trunk/python/qpid_dispatch/management/qdrouter.json 1659590 > trunk/python/qpid_dispatch_internal/router/node.py 1659590 > > Diff: https://reviews.apache.org/r/31121/diff/ > > > Testing > ------- > > I have used it from my 'topologist' testing program for a couple hundred > iterations with no obvious ill effects. > > > Thanks, > > michael goulish > >
