> On Feb. 21, 2015, 1:08 p.m., Robbie Gemmell wrote: > > The change seems fine from a licence point of view, replacing the > > previously added .cmake file rather than figuring out if it is permissable > > to include it and updating the LICENCE etc accordingly. > > > > From a CMake and C++ perspective I have no idea really, but accepting that > > it looks fine to me :)
I echo Robbie's sentiment. I'd like to approve it, but we should get someone with a cmake eye on it. Steve, would you add Andrew to the review? - Justin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31237/#review73404 ----------------------------------------------------------- On Feb. 20, 2015, 7:52 p.m., Steve Huston wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31237/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2015, 7:52 p.m.) > > > Review request for qpid, Justin Ross and Robbie Gemmell. > > > Bugs: QPID-6312 > https://issues.apache.org/jira/browse/QPID-6312 > > > Repository: qpid > > > Description > ------- > > I started with simply reimplementing a size_t native check under ASF license > and learned that wasn't the whole story for Qpid's needs. It requires a check > to see if size_t is distinct from the other int types in qpid/IntegerTypes.h. > This patch is the result and, I think, more reliable and fitted to our needs > than the previous mechanism. > > > Diffs > ----- > > trunk/qpid/cpp/CMakeModules/CheckSizeTNativeType.cmake 1661190 > trunk/qpid/cpp/CMakeModules/CheckSizetDistinct.cmake PRE-CREATION > trunk/qpid/cpp/src/CMakeLists.txt 1661190 > trunk/qpid/cpp/src/config.h.cmake 1661190 > trunk/qpid/cpp/src/qpid/Options.cpp 1661190 > > Diff: https://reviews.apache.org/r/31237/diff/ > > > Testing > ------- > > cmake on AIX (where the result is 'yes') and Linux (where the result is 'no'). > If this patch is acceptable, I will request it be merged to 0.32 as well. > > > Thanks, > > Steve Huston > >
