----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31330/#review73728 -----------------------------------------------------------
There seems to be nothing wrong here, but it makes me ask what else changed to make this change necessary. I'd be particularly concerned that the equivalent non-test code inside the broker and other executables didn't changing. - Andrew Stitcher On Feb. 24, 2015, midnight, Steve Huston wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31330/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, midnight) > > > Review request for qpid and Andrew Stitcher. > > > Bugs: QPID-6409 > https://issues.apache.org/jira/browse/QPID-6409 > > > Repository: qpid > > > Description > ------- > > Patch to avoid taking addres and calling parse if there are no arguments. > > > Diffs > ----- > > trunk/qpid/cpp/src/tests/BrokerFixture.h 1661591 > > Diff: https://reviews.apache.org/r/31330/diff/ > > > Testing > ------- > > Compile, run unit_test > > > Thanks, > > Steve Huston > >
