----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31506/#review74385 -----------------------------------------------------------
trunk/qpid/cpp/src/qpid/broker/PersistableQueue.h <https://reviews.apache.org/r/31506/#comment120952> 1. With the zeroing out you don't need the test as you can always delete a nullptr with no effect. 2. If with the zeroing out it's not clear to me that you solve the problem, because I think it's an analysis based on simultaneous deletion in multiple threads. 3. So I think the correct solution might be somthing like - set x = nullptr; atomic_swap externalQueueStore and x; delete x; - Andrew Stitcher On Feb. 26, 2015, 10:56 p.m., Steve Huston wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31506/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, 10:56 p.m.) > > > Review request for qpid and Andrew Stitcher. > > > Bugs: QPID-6368 > https://issues.apache.org/jira/browse/QPID-6368 > > > Repository: qpid > > > Description > ------- > > Ensure there's no double free in the destructor. This was flagged by Coverity > as an issue. I trust Coverity's sense of an error more than mine, but am > interested in having more expert C++ eyes check this out. > > > Diffs > ----- > > trunk/qpid/cpp/src/qpid/broker/PersistableQueue.h 1662342 > > Diff: https://reviews.apache.org/r/31506/diff/ > > > Testing > ------- > > Build, test suite. > > > Thanks, > > Steve Huston > >
