[
https://issues.apache.org/jira/browse/QPID-6389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343070#comment-14343070
]
Robbie Gemmell commented on QPID-6389:
--------------------------------------
I verified that the above commit now makes the broker return a null source
rather than a source with null address.
On further reading and discussion of the spec it does seem to be ok for the
following detach to contain an error in this case, so that part of the raised
issue isn't entirely vali (I'll update the description and name), though It
would still be nice if the broker insead sent the amqp:not-found error
condition when the link can't be [re]attached because it doesnt exist, rather
than the current amqp:precondition-failed.
> [C++ Broker] [AMQP 1.0] consumer attach with a null source can lead to
> unexpected error in resulting detach
> -----------------------------------------------------------------------------------------------------------
>
> Key: QPID-6389
> URL: https://issues.apache.org/jira/browse/QPID-6389
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker
> Affects Versions: 0.31
> Reporter: Robbie Gemmell
> Assignee: Gordon Sim
>
> Upon a client attaching a durable consumer link with a null source (not null
> address), qpidd responds with an attach containing a non-null source with
> null address, then sends a closing detach with an error indicating no source
> was specfied. The message "[Protocol] error Error on attach: No source
> specified!" is output on the broker console.
> From the spec, I would expect this to have resulted in either:
> * A successfull attach to an existing \[possibly detached\] link, with the
> response source indicating the related terminus details.
> * Returning an attach with a null source, and then a closing detach without
> an error, to indicate lack of a matching link.
> This behaviour seems to be described at
> http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#doc-idp315568
> with Fig 2.33 in particular being related, albeit for a producing link.
> The JMS clients (old and new) currently do this to 'look up' durable
> subscriptions by attaching a link with a null source (only during unsubscribe
> currently, but in future also during subscriber open/creation verification as
> well), and monitoring the source value in the attach response from the broker.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
