-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31746/
-----------------------------------------------------------

(Updated March 5, 2015, 9:08 p.m.)


Review request for qpid, Alan Conway, Ernie Allen, michael goulish, and Ted 
Ross.


Bugs: DISPATCH-98
    https://issues.apache.org/jira/browse/DISPATCH-98


Repository: qpid-dispatch


Description
-------

Allow the independent setting of each supported message annotation.

First, the message annotation map of a received message is walked, and the 
known annotations (trace, to-override, ingress) are identified.

During that processing, updated values for these fields may be created.  Each 
updated value is encoded into its own buffer chain.  Each buffer chain is 
stored individually in the per-reference (private) part of the message 
structure.

If the message is copied, any message annotation buffers are cloned.   The 
annotations can be overridden without affecting the annotations in the source 
message.

When the message is to be sent, the buffer chains containing the new 
annotations are 'spliced' into the outgoing message.


Diffs (updated)
-----

  trunk/include/qpid/dispatch/buffer.h 1664131 
  trunk/include/qpid/dispatch/compose.h 1664131 
  trunk/include/qpid/dispatch/ctools.h 1664131 
  trunk/include/qpid/dispatch/message.h 1664131 
  trunk/src/buffer.c 1664131 
  trunk/src/compose.c 1664131 
  trunk/src/message.c 1664131 
  trunk/src/message_private.h 1664131 
  trunk/src/router_node.c 1664131 
  trunk/tests/CMakeLists.txt 1664131 
  trunk/tests/buffer_test.c PRE-CREATION 
  trunk/tests/compose_test.c 1664131 
  trunk/tests/message_test.c 1664131 
  trunk/tests/run_unit_tests_size.c 1664131 

Diff: https://reviews.apache.org/r/31746/diff/


Testing
-------

New unit tests for the new methods introduced by this patch.


Thanks,

Kenneth Giusti

Reply via email to