----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31812/#review75885 -----------------------------------------------------------
trunk/qpid/cpp/src/tests/CMakeLists.txt <https://reviews.apache.org/r/31812/#comment123208> I strongly agree that the options should be the same across both platforms, so I think it is a blocker to the release of the tests. So I think if the options can't use "--option" on Windows then we *must* change the shell script and build to use "-option" Remember the fewer differences between platforms the easier ongoing maintenance will be, even if it means a larger change now to make them the same. FWIW my preferences would be to use python on all platforms instead of shell and powershell. - Andrew Stitcher On March 6, 2015, 11:02 p.m., Steve Huston wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31812/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 11:02 p.m.) > > > Review request for qpid, Alan Conway and Cliff Jansen. > > > Bugs: QPID-6399 > https://issues.apache.org/jira/browse/QPID-6399 > > > Repository: qpid > > > Description > ------- > > As noted in QPID-6399, the way run_tests takes in test info and runs test > programs has changed and run_test.ps1 needs to be changed to match. To do > this I: > - Added parameters to the run_test.ps1 script to easily take the command line > arguments. The way powershell does this is, of course, different from > anything else. They use one dash instead of two and there's no concept of > long vs. short names. Thus, the way to specify the arguments is different > between Linux and Windows. > - Changed CMakeLists.txt to adapt to the different argument-passing > mechanisms. > - Added some help to test_env.ps1.in to help set up run-time paths. > > > Diffs > ----- > > trunk/qpid/cpp/src/tests/CMakeLists.txt 1664535 > trunk/qpid/cpp/src/tests/run_test.ps1 1664535 > trunk/qpid/cpp/src/tests/test_env.ps1.in 1664535 > > Diff: https://reviews.apache.org/r/31812/diff/ > > > Testing > ------- > > Run all the cpp/src/tests on Windows. They all fail, but they do at least run. > > > Thanks, > > Steve Huston > >
