[
https://issues.apache.org/jira/browse/QPID-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14489856#comment-14489856
]
Alex Rudyy edited comment on QPID-6489 at 4/15/15 9:25 AM:
-----------------------------------------------------------
Keith,
Please, review the changes made under revisions [
r1673690|https://svn.apache.org/r1673690 ] and [
r1672692|https://svn.apache.org/r1672692 ]
was (Author: alex.rufous):
Keith,
Please, review the changes
> Test FailoverBehaviourTest.testFlowControlFlagResetOnFailover fails because
> it manages to send more messages than expected before flow is blocked
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-6489
> URL: https://issues.apache.org/jira/browse/QPID-6489
> Project: Qpid
> Issue Type: Bug
> Reporter: Alex Rudyy
> Assignee: Keith Wall
>
> Test FailoverBehaviourTest.testFlowControlFlagResetOnFailover expects to send
> 3 or 4 messages before flow is blocked. However, with new io layer flow
> command arrives whilst test is sending 5th message:
> {noformat}
> 2015-04-06 08:08:39,404 INFO [IoReceiver-localhost/127.0.0.1:15672]
> (qpid.protocol) - RECV:
> [org.apache.qpid.client.protocol.AMQProtocolHandler@3c32b13f] Frame
> channelId: 1, bodyFrame: [ChannelFlowBodyImpl: active=false]
> 2015-04-06 08:08:39,404 DEBUG [IoReceiver-localhost/127.0.0.1:15672]
> (protocol.AMQProtocolHandler) - (1009955135)Method frame received:
> [ChannelFlowBodyImpl: active=false]
> 2015-04-06 08:08:39,405 DEBUG [Thread-3141] (client.BasicMessageProducer_0_8)
> - Sending content body frames to
> direct://amq.direct/FailoverBehaviourTest-testFlowControlFlagResetOnFailover/FailoverBehaviourTest-testFlowControlFlagResetOnFailover?routingkey='FailoverBehaviourTest-testFlowControlFlagResetOnFailover'&durable='true'
> 2015-04-06 08:08:39,405 DEBUG [Thread-3141] (client.BasicMessageProducer_0_8)
> - Sending content header frame to
> direct://amq.direct/FailoverBehaviourTest-testFlowControlFlagResetOnFailover/FailoverBehaviourTest-testFlowControlFlagResetOnFailover?routingkey='FailoverBehaviourTest-testFlowControlFlagResetOnFailover'&durable='true'
> 2015-04-06 08:08:39,405 DEBUG [Thread-3141] (framing.FieldTable) -
> FieldTable::writeToBuffer: Writing encoded length of 34...
> 2015-04-06 08:08:39,405 DEBUG [Thread-3141] (framing.FieldTable) -
> {index=[INT: 4], JMS_QPID_DESTTYPE=[INT: 1]}
> 2015-04-06 08:08:39,405 INFO [IoReceiver-localhost/127.0.0.1:15672]
> (client.AMQSession) - Broker enforced flow control has been enforced
> 2015-04-06 08:08:39,405 DEBUG [Thread-3141] (qpid.protocol) - SEND:
> [org.apache.qpid.client.protocol.AMQProtocolHandler@3c32b13f]
> org.apache.qpid.framing.CompositeAMQDataBlock{ 0=[Frame channelId: 1,
> bodyFrame: [BasicPublishBodyImpl: ticket=0, exchange=amq.direct,
> routingKey=FailoverBehaviourTest-testFlowControlFlagResetOnFailover,
> mandatory=true, immediate=false]] 1=[Frame channelId: 1, bodyFrame:
> ContentHeaderBody{classId=60, weight=0, bodySize=1024, properties=reply-to =
> null,propertyFlags = 47312,ApplicationID = null,ClusterID = null,UserId =
> admin,JMSMessageID = ID:f55c854f-dba5-35d7-8149-d02fadd8865d,JMSCorrelationID
> = null,JMSDeliveryMode = 2,JMSExpiration = 0,JMSPriority = 4,JMSTimestamp =
> 1428322119404,JMSType = null}] 2=[Frame channelId: 1, bodyFrame:
> org.apache.qpid.framing.ContentBody@4d6094ee]}
> 2015-04-06 08:08:39,405 DEBUG [Thread-3141] (qpid.protocol) - SEND:
> [org.apache.qpid.client.protocol.AMQProtocolHandler@3c32b13f] Frame
> channelId: 1, bodyFrame: [TxCommitBody]
> 2015-04-06 08:08:39,405 DEBUG [IO-/127.0.0.1:43713]
> (transport.NonBlockingConnection) - Written 0 bytes
> 2015-04-06 08:08:39,405 DEBUG [IO-/127.0.0.1:43713]
> (transport.NonBlockingConnection) - Read 1254 byte(s)
> 2015-04-06 08:08:39,405 DEBUG [IO-/127.0.0.1:43713] (v0_8.AMQChannel) -
> RECV[1] BasicPublish[ exchange: amq.direct routingKey:
> FailoverBehaviourTest-testFlowControlFlagResetOnFailover mandatory: true
> immediate: false ]
> 2015-04-06 08:08:39,405 DEBUG [IO-/127.0.0.1:43713] (v0_8.BrokerDecoder) -
> Frame handled in 0 ms.
> 2015-04-06 08:08:39,405 DEBUG [IO-/127.0.0.1:43713]
> (framing.BasicContentHeaderProperties) - Property flags: 47312
> 2015-04-06 08:08:39,405 DEBUG [IO-/127.0.0.1:43713] (v0_8.AMQChannel) -
> RECV[1] MessageHeader[ properties: {reply-to = null,propertyFlags =
> 47312,ApplicationID = null,ClusterID = null,UserId = admin,JMSMessageID =
> ID:f55c854f-dba5-35d7-8149-d02fadd8865d,JMSCorrelationID =
> null,JMSDeliveryMode = 2,JMSExpiration = 0,JMSPriority = 4,JMSTimestamp =
> 1428322119404,JMSType = null} bodySize: 1024 ]
> 2015-04-06 08:08:39,405 DEBUG [IO-/127.0.0.1:43713] (v0_8.AMQChannel) -
> Content header received on channel 1
> 2015-04-06 08:08:39,405 DEBUG [IO-/127.0.0.1:43713] (v0_8.BrokerDecoder) -
> Frame handled in 0 ms.
> 2015-04-06 08:08:39,405 DEBUG [IO-/127.0.0.1:43713] (v0_8.AMQChannel) -
> RECV[1] MessageContent[ data:
> 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000...
> ]
> 2015-04-06 08:08:39,405 DEBUG [IO-/127.0.0.1:43713] (v0_8.AMQChannel) -
> 1(395533021) content body received on channel 1
> 2015-04-06 08:08:39,405 DEBUG [IO-/127.0.0.1:43713] (txn.LocalTransaction) -
> Enqueue of message number 5 to transaction log. Queue :
> FailoverBehaviourTest-testFlowControlFlagResetOnFailover
> {noformat}
> It seems that test needs to be fixed to account that Flow.active=false can
> arrive with a delay, thus, publishing of 5 messages before flow is blocked
> should be acceptible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
