[
https://issues.apache.org/jira/browse/QPID-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511051#comment-14511051
]
ASF subversion and git services commented on QPID-6508:
-------------------------------------------------------
Commit 1675856 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1675856 ]
QPID-6506, QPID-6508: [Java Client] PropertiesFileInitialContextFactory no
longer swallows exceptions, pollutes the system properties, nor modifies the
environment.
IOExceptions and URISyntaxExceptions that were previously swallowed are now
chained to a NamingException.
If the environment needs to be modified within the method a copy is created.
System properties are no longer set.
work done by Lorenz Quack <[email protected]> and Keith Wall
<[email protected]>
> PropertiesFileInitialContextFactory silences important exceptions and is
> non-compliant with the InitialContext interface
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-6508
> URL: https://issues.apache.org/jira/browse/QPID-6508
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.32
> Reporter: Lorenz Quack
> Priority: Minor
> Fix For: 6.0 [Java]
>
> Attachments:
> 0001-QPID-6506-QPID-6508-Java-Client-PropertiesFileInitia.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> 1) PropertiesFileInitialContextFactory.getInitialContext catches IOExceptions
> and URISyntaxExceptions logs a warning and then does not re-throw the
> exception.
> If users don't have logging set to warning they will miss important
> information.
> 2) PropertiesFileInitialContextFactory.getInitialContext modifies the
> environment parameter which is not conformant. To quote the
> InitialContextFactory.getInitialContext JavaDoc: "The environment parameter
> is owned by the caller. The implementation will _not modify the object_ or
> keep a reference to it \[...\]" (emphasis mine)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
