On 14 May 2015 at 07:32, Andrew Stitcher <[email protected]> wrote: > On Thu, 2015-05-07 at 17:14 +0100, Robbie Gemmell wrote: >> Chucks recent Pull Request update made me look at what we have open. >> There was one that looks complete from the JIR, but wasnt closed via >> the commits, so I commented asking the user to close it. >> >> For the other, which has been there for a month, there is a set of >> changes to get the C++ bits building on OSX, which I recalled someone >> also asked about on the user list recently: >> >> https://github.com/apache/qpid/pull/7 >> >> Anyone able to look at it? > > I looked at it and commented. I didn't think it was very good. Too > intrusive in the existing code unnecessarily. > > Andrew >
Thanks for looking. This is why I didnt just try compiling it and whack it in myself, better that someone with a clue about the code in question looks at things :) Robbie --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
