> On May 21, 2015, 4:50 p.m., Gordon Sim wrote: > > Works for me... however it says 'Successfully installed > > python-qpid-proton-0.9', even though I was installing from master (which is > > now 0-10). Where does it get the version from?
Hi Gordon - the setup.py file doesn't install from the build directory. We still use cmake for that. These setup files are designed specifically for installing the python wrappers from PyPi. They ensure that the proper corresponding libqpid-proton library is available on the host system, and if not pulls the correct version of the proton C sources from Apache and builds/installs the library. To enforce that the version of the wrapper files match the correct version of the libqpid-proton library, the version # is hardcoded in the setuputils/bundle.py file. Not ideal - we should have the release process automate that. Something I can add before we release 0.10. while we -could- make the setup.py also install from the build directory, seemed like that was redundant given cmake's capability. Certainly willing to reconsider that, tho. - Kenneth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34511/#review84731 ----------------------------------------------------------- On May 21, 2015, 12:13 a.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34511/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 12:13 a.m.) > > > Review request for qpid. > > > Bugs: PROTON-885 > https://issues.apache.org/jira/browse/PROTON-885 > > > Repository: qpid-proton-git > > > Description > ------- > > Work contributed by Flavio Percoco > > > Diffs > ----- > > LICENSE 4956407 > proton-c/bindings/python/MANIFEST.in PRE-CREATION > proton-c/bindings/python/setup.py cdfa104 > proton-c/bindings/python/setuputils/PYZMQ_LICENSE.BSD PRE-CREATION > proton-c/bindings/python/setuputils/__init__.py PRE-CREATION > proton-c/bindings/python/setuputils/bundle.py PRE-CREATION > proton-c/bindings/python/setuputils/log.py PRE-CREATION > proton-c/bindings/python/setuputils/misc.py PRE-CREATION > > Diff: https://reviews.apache.org/r/34511/diff/ > > > Testing > ------- > > Tested setup.py build and sdist both with and without libqpid-proton + > headers present. > Also tested install from generated source distribution. > > > Thanks, > > Kenneth Giusti > >
