[ 
https://issues.apache.org/jira/browse/QPID-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566791#comment-14566791
 ] 

Keith Wall commented on QPID-6451:
----------------------------------

Alex, can you review this commit please?

> ProtocolVersionException exception logged at error as Java Client downgrades 
> from 0-10
> --------------------------------------------------------------------------------------
>
>                 Key: QPID-6451
>                 URL: https://issues.apache.org/jira/browse/QPID-6451
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>    Affects Versions: 0.32
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>            Priority: Minor
>             Fix For: 6.0 [Java]
>
>
> Since QPID-6350, the Java Client 0-10 has been logging ConnectionExceptions 
> at SLF4J error. Unfortunately this change also causes   
> ProtocolVersionException (and RedirectConnectionException) to be logged too. 
> These exceptions don't represent true error conditions, so logging them at 
> error is inappropriate.
> Whilst this change does not cause a functional issue, it has the potential to 
> confuse users and can unnecessarily pollute logs.  
> {noformat}
> 2015-03-14 18:40:13,562 ERROR [IoReceiver-localhost/127.0.0.1:15672] 
> (transport.Connection) - exception: version mismatch: 0-9
> org.apache.qpid.transport.ProtocolVersionException: version mismatch: 0-9
>         at 
> org.apache.qpid.transport.ClientDelegate.init(ClientDelegate.java:61)
>         at 
> org.apache.qpid.transport.ClientDelegate.init(ClientDelegate.java:44)
>         at 
> org.apache.qpid.transport.ProtocolHeader.delegate(ProtocolHeader.java:110)
>         at org.apache.qpid.transport.Connection.received(Connection.java:416)
>         at org.apache.qpid.transport.network.Assembler.emit(Assembler.java:98)
>         at 
> org.apache.qpid.transport.network.Assembler.init(Assembler.java:118)
>         at 
> org.apache.qpid.transport.ProtocolHeader.delegate(ProtocolHeader.java:115)
>         at 
> org.apache.qpid.transport.network.Assembler.received(Assembler.java:103)
>         at 
> org.apache.qpid.transport.network.InputHandler.next(InputHandler.java:163)
>         at 
> org.apache.qpid.transport.network.InputHandler.received(InputHandler.java:115)
>         at 
> org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:161)
>         at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to