----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35214/#review87078 -----------------------------------------------------------
proton-c/src/platform.c <https://reviews.apache.org/r/35214/#comment139353> why uint16_t not uint8_t? proton-c/src/platform.c <https://reviews.apache.org/r/35214/#comment139355> not sure exactly what this code does. rand() returns < RAND_MAX, so the division will result in something < 0, which is still likely to be zero after multiplying it by 255 then casting to an int. why not use all the non-zero bytes available in the value returned from rand()? Won't that be more 'random'? - Kenneth Giusti On June 8, 2015, 7:32 p.m., Flavio Percoco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35214/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 7:32 p.m.) > > > Review request for qpid and Rafael Schloming. > > > Repository: qpid-proton-git > > > Description > ------- > > Instead of relying on libuuid for uuid generation, let proton-c have a > built-in uuid4 generator as a fallback when no uuid generator is present in > the system. > > Eventually, proton-c could simply rely on the built-in generator but lets > give this some time to mature and test. > > > Diffs > ----- > > proton-c/CMakeLists.txt b534e86 > proton-c/bindings/python/setup.py 79168d2 > proton-c/src/platform.c 8f8ac5f > > Diff: https://reviews.apache.org/r/35214/diff/ > > > Testing > ------- > > > Thanks, > > Flavio Percoco > >
