----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35369/#review87719 -----------------------------------------------------------
Ship it! This change makes the python-tox-test work exactly as I would expect it to: pip install the locally generated python-qpid-proton sdist in a virtualenv using the local proton-c sources (not sources downloaded from apache). This is perfect. - Kenneth Giusti On June 11, 2015, 8:39 p.m., Flavio Percoco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35369/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 8:39 p.m.) > > > Review request for qpid, Gordon Sim, Kenneth Giusti, and Rafael Schloming. > > > Repository: qpid-proton-git > > > Description > ------- > > Since we're not using cmake anymore, we can let tox handle the sdist and > install steps so that everything happens within the tox venv. > > > Diffs > ----- > > proton-c/bindings/python/tox.ini aab5e4e > > Diff: https://reviews.apache.org/r/35369/diff/ > > > Testing > ------- > > > Thanks, > > Flavio Percoco > >
