----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35360/ -----------------------------------------------------------
(Updated June 15, 2015, 10:06 p.m.) Review request for qpid, Gordon Sim and Rafael Schloming. Changes ------- This patch addresses Ken's comments. cmake now exports the QPID_SRC_PROTON env variable itself. To run this `build` tests using pure tox, the env var will have to be exported manually for now since it's needed by the sdist step which is executed before `tox` exports the registered env variables. Repository: qpid-proton-git Description ------- The patch allows python-qpid-proton for generating the `cproton_wrap.c` file when creating the distribution package. Since this file is already cross-platform, it should be safe to ship it as part of the python-qpid-proton package. This allows us for building the bindings even when swig is not available. The setup.py process will try to generate a new cproton_wrap.c everytime but it'll fallback to the one distributed with the package if swig is not available. Note that this will be done just in the platforms where bundling proton-c is supported. The reason being that, in the other platforms, w can't verify whether the installed qpid-proton version is the same that was used to generated these files Diffs (updated) ----- proton-c/CMakeLists.txt 5b05e38 proton-c/bindings/python/setup.py 84b5a66 Diff: https://reviews.apache.org/r/35360/diff/ Testing ------- Thanks, Flavio Percoco
