-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35546/
-----------------------------------------------------------
Review request for qpid.
Bugs: qpid-6592
https://issues.apache.org/jira/browse/qpid-6592
Repository: qpid
Description
-------
Adds the 'product', 'host', 'version', and 'platform' fields to the connection
properties (1.0) or server-properties (0-10) during the connection setup.
Diffs
-----
trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.h 1685594
trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1685594
trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1685594
Diff: https://reviews.apache.org/r/35546/diff/
Testing
-------
all unit tests pass.
The broker logs the following during trace of a 1.0 connection:
2015-06-16 17:00:04 [Protocol] trace [qpid.127.0.0.1:5672-127.0.0.1:60423]: 0
-> @open(16) [container-id="77b4947b-d642-4564-a43c-79aa3e2cded9",
properties={:product="qpid-cpp", :version="0.33", :platform="Linux",
:host="t530.localdomain"}]
and for 0-10:
2015-06-16 16:30:38 [Protocol] trace SENT
[qpid.127.0.0.1:5672-127.0.0.1:54270]: Frame[BEbe; channel=0;
{ConnectionStartBody:
server-properties={host:V2:16:str16(t530.localdomain),platform:V2:5:str16(Linux),product:V2:8:str16(qpid-cpp),qpid.federation_tag:V2:36:str16(7ab538ed-3a1d-442a-840b-038031dcf239),version:V2:4:str16(0.33)};
mechanisms=str16{V2:9:str16(ANONYMOUS), V2:5:str16(PLAIN)};
locales=str16{V2:5:str16(en_US)}; }]
Thanks,
Kenneth Giusti
