A couple of new tests were added in http://svn.apache.org/r1686284. One of these, testReservedExchangeRedeclaredSameType, verifies that amq.direct can be redeclared using the correct type with passive set to false as well as to true.

I believe testing for declare of any standard exchange with passive=false is incorrect. The spec states:

    Exchange names starting with "amq." are reserved for pre-declared
    and standardized exchanges. The client MUST NOT attempt to create
    an exchange starting with "amq.".

A declare with passive=false is a request to create as far as the client is concerned. The broker should in my view raise an error in that case even if the exchange exists, since the client is doing something forbidden by the spec. Certainly testing that the broker allows it seems wrong.

If there is no disagreement, I will remove the line from the test. It will still test that you can passively declare the exchange, as that is completely legitimate.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to