> On June 23, 2015, 7:48 p.m., Kenneth Giusti wrote:
> > I think you may also have to add code into the python binding for the
> > 'channel_max' property of the transport that checks for the error and then
> > throws the exception.
Yes, sorry -- I had that in there but it somehow weaseled out of this diff
It looks like this:
- pn_transport_set_channel_max(self._impl, value)
+ if(pn_transport_set_channel_max(self._impl, value)):
+ raise(SessionException("Too late to change channel max."))
- michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35798/#review89040
-----------------------------------------------------------
On June 23, 2015, 6:49 p.m., michael goulish wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35798/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 6:49 p.m.)
>
>
> Review request for qpid, Andrew Stitcher and Kenneth Giusti.
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> Alter C impl to return error code if we attempt to change local channel_max
> after OPEN frame has been sent. Also alter python binding to detect that
> error code, and throw exception. This way, the C and Java versions of one of
> the test of channel_max functionality have the same behavior.
>
>
> Diffs
> -----
>
> proton-c/include/proton/error.h c6c7d2e
> proton-c/include/proton/transport.h 483f5a9
> proton-c/src/transport/transport.c ff80e21
> tests/python/proton_tests/engine.py 258665d
>
> Diff: https://reviews.apache.org/r/35798/diff/
>
>
> Testing
> -------
>
> ctest -VV --- C and Java
>
>
> Thanks,
>
> michael goulish
>
>
