----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36012/#review89811 -----------------------------------------------------------
As with review 36020 I think the approach here is flawed because of CMake string and list handling se that review for details. trunk/qpid/cpp/src/tests/CMakeLists.txt (line 41) <https://reviews.apache.org/r/36012/#comment142605> This whole approach is now obsolete and should be replaced with $<TARGET_FILE:test_whatever> (Although this comment is not a comment on this change per se) - Andrew Stitcher On June 29, 2015, 9:09 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36012/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 9:09 p.m.) > > > Review request for qpid, Andrew Stitcher and Steve Huston. > > > Bugs: qpid-6611 > https://issues.apache.org/jira/browse/qpid-6611 > > > Repository: qpid > > > Description > ------- > > Qpid creates executable files in many folders in the build tree. Simple > programs like hello_world.exe don't execute in the folder in which it is > created. This patch creates them all where they are most likely to run. They > will be integrated with Visual Studio and files from different configurations > will not overlap. That is the output files will be in <build>\src\Debug, > <build>\src\RelWithDebInfo, and so on. > > > Diffs > ----- > > trunk/qpid/cpp/CMakeLists.txt 1682976 > trunk/qpid/cpp/bindings/qmf2/examples/cpp/CMakeLists.txt 1682976 > trunk/qpid/cpp/examples/messaging/CMakeLists.txt 1682976 > trunk/qpid/cpp/src/tests/CMakeLists.txt 1682976 > > Diff: https://reviews.apache.org/r/36012/diff/ > > > Testing > ------- > > No difference in ctest behavior for windows or for linux builds. > > > Thanks, > > Chug Rolke > >
