----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36020/#review89905 -----------------------------------------------------------
Similar to the Qpid C++ change that's analogous to this, I prefer to use PATH and installers to take care of this problem. OS-specific things I'd rather keep out of the cmake files. They're tangled up enough as it is. - Steve Huston On June 29, 2015, 9:07 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36020/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 9:07 p.m.) > > > Review request for qpid, Andrew Stitcher and Steve Huston. > > > Bugs: proton-926 > https://issues.apache.org/jira/browse/proton-926 > > > Repository: qpid-proton-git > > > Description > ------- > > Same as https://issues.apache.org/jira/browse/QPID-6611 for qpid this patch > creates .exe files in common place. It is windows only with no change for > linux. > > The patch moves intermediate files around in the build tree only. It does not > change the layout of the install directory. > > > Diffs > ----- > > examples/c/messenger/CMakeLists.txt 1b32d0c > proton-c/CMakeLists.txt a1cf0e4 > proton-c/src/tests/CMakeLists.txt ac749e1 > tests/tools/apps/c/CMakeLists.txt 9507c1f > > Diff: https://reviews.apache.org/r/36020/diff/ > > > Testing > ------- > > Passes all tests on windows and linux. > > > Thanks, > > Chug Rolke > >
