----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36137/#review90251 -----------------------------------------------------------
IMO Don't make this a separate check in. Just commit it with whatever other change relies on it. Otherwise you are adding a confusing unused file into the source tree (at least temporarily). [Perhaps the change that uses this one will never get committed] Also for constants specified in the AMQP Protocol look at the generated file proton-c/src/protocol.h and the script which generates it proton-c/src/protocol.h.py. If you are going to have constants specified in the protocol then autogenerating them from the Spec XML seems like the way to go. - Andrew Stitcher On July 2, 2015, 5:13 p.m., michael goulish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36137/ > ----------------------------------------------------------- > > (Updated July 2, 2015, 5:13 p.m.) > > > Review request for qpid, Andrew Stitcher, Gordon Sim, Kenneth Giusti, and Ted > Ross. > > > Repository: qpid-proton-git > > > Description > ------- > > PROTON-930: make a new .h file that contains defined constants for every > numeric default value that is mandated by the AMQP 1.0 spec > > > Diffs > ----- > > proton-c/include/proton/amqp_1_0_constants.h PRE-CREATION > > Diff: https://reviews.apache.org/r/36137/diff/ > > > Testing > ------- > > make -j4 > > :-) > > I'm not actually using any of these constant with this patch, but I would > like to use them in some other patches I am working on. > > > Thanks, > > michael goulish > >
