----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36480/#review91792 -----------------------------------------------------------
trunk/python/qpid_dispatch/management/qdrouter.json (line 896) <https://reviews.apache.org/r/36480/#comment145440> I would make listener required and drop the short-cut for addr/port. There's a lot more to a listener than the address: sasl, ssl config, management visibility etc. It's easy to define a listener with just addr & port if that's what you want. trunk/python/qpid_dispatch/management/qdrouter.json (line 899) <https://reviews.apache.org/r/36480/#comment145441> Suggest dropping dir, make proxy & home absolute. Binaries and data files often live in unrelated directories (e.g. /usr/bin and /usr/share) and abs paths will still work if they happen to be in some common dir. trunk/python/qpid_dispatch_internal/management/agent.py (line 320) <https://reviews.apache.org/r/36480/#comment145443> If we drop stdout/stderr then we are assuming the proxy can be configured for debug logging. That's probably OK just want to make sure we allow that. E.g. do we allow passing command-line params to the proxy to turn on logging or set a log file? - Alan Conway On July 14, 2015, 6:55 p.m., Ernie Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36480/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 6:55 p.m.) > > > Review request for qpid, Alan Conway, Ganesh Murthy, Kenneth Giusti, mick > goulish, and Ted Ross. > > > Repository: qpid-dispatch > > > Description > ------- > > This modifies the schema by adding a console entity. In the console entity > you can define the attributes needed to run a proxy server that translates > websockets to tcp and also serves http file requests. > > listener { > ... > name: proxy > ... > } > > console { > listener: proxy > dir: /home/eallen/dispatch-svn/tools/websockify/ > home: webapps > proxy: qdproxy > wsport: 5673 > } > > > Diffs > ----- > > trunk/python/qpid_dispatch/management/qdrouter.json 1690252 > trunk/python/qpid_dispatch_internal/management/agent.py 1690252 > > Diff: https://reviews.apache.org/r/36480/diff/ > > > Testing > ------- > > bin/test.sh passes all tests. > I replaced the nodejs proxy I was using with the new python/websockify server. > In the 6 router network, I changed A.conf and added a name to the listener > and added a console section that runs the python proxy/server. > > The web console retrieves all html/js/css files, connects and communicates to > the router network through the proxy. > > > Thanks, > > Ernie Allen > >
