[
https://issues.apache.org/jira/browse/QPID-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743333#comment-14743333
]
Alex Rudyy edited comment on QPID-6736 at 9/14/15 10:26 AM:
------------------------------------------------------------
Keith,
One thing I would do differently is how context variable values are get
evaluated: instead of calling connection.getBroker().getContextValue(...) or
connection.getVirtualHost().getContextValue(...) I would change AMQChannel to
call connection.getContextValue(...). In that case, we could get rid of public
method getBroker() and extra unnecessary steps in test setup to mock broker and
virtual host.
Apart from above the rest of changes look reasonable to me.
was (Author: alex.rufous):
Keith,
One thing I would do differently is how context variable values are get
evaluated: instead of calling connection.getBroker().getContextValue(...) or
connection.getVirtualHost().getContextValue(...) I would change AMQChannel to
call connection.getContextValue(...). In that case, we could get rid of public
method getBroker() and extra unnecessary steps in test setups to mock for
broker and virtual host.
Apart from above the rest of changes look reasonable to me.
> Rewrite 0-8..0-91 connection / session units tests
> --------------------------------------------------
>
> Key: QPID-6736
> URL: https://issues.apache.org/jira/browse/QPID-6736
> Project: Qpid
> Issue Type: Improvement
> Components: Java Tests
> Reporter: Keith Wall
> Assignee: Keith Wall
> Priority: Minor
> Fix For: qpid-java-6.0
>
>
> Current tests rely on a test-only implementation of AMQConnection_0_8
> (InternalTestProtocolSession) which makes it difficult to know if a test is
> testing production or test-only code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
