-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38688/
-----------------------------------------------------------
Review request for qpid and Kenneth Giusti.
Bugs: PROTON-1000 and PROTON-1003
https://issues.apache.org/jira/browse/PROTON-1000
https://issues.apache.org/jira/browse/PROTON-1003
Repository: qpid-proton-git
Description
-------
The lack of an error handler means that when a connection is timed out locally
due to not receiving expected heartbeats from peer, the ssl layer (when active)
doesn't know about this and so the socket is never closed.
Diffs
-----
proton-c/src/engine/engine-internal.h faba488
proton-c/src/sasl/sasl.c fb98894
proton-c/src/ssl/openssl.c 2781a5b
proton-c/src/transport/transport.c 96ac2a8
Diff: https://reviews.apache.org/r/38688/diff/
Testing
-------
make test passes, ssl based reproducer from PRTON-1000 also shows sockets being
closed.
Thanks,
Gordon Sim
