[
https://issues.apache.org/jira/browse/QPID-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935237#comment-14935237
]
Lorenz Quack commented on QPID-6744:
------------------------------------
Hey Keith, I reviewed your changes:
* Not a big fan of these names: {{String
CONNECTION_QUEUE_DELETE_NOWAIT_VERSION_REGEXP =
"connection.queueDeleteNoWaitVersionRegexp";}} I think I would prefer something
along the lines of what you use elsewhere. Something like
{{sendQueueDeleteOkRegardlessClientVersionRegExp}} Not nice but at least a bit
more descriptive. what do you think.
* In AMQChannel.java:3109 should the creation of the response body not better
move inside the new {{if(!nowait)}}?
* May I suggest a slight rewording in AMQPConnection_0_8.java: From {{QPID-6744
- Older queue clients (<=0.32) incorrectly set the nowait flag false on the
queue.delete method and then await regardless.}} to {{QPID-6744 - Older queue
clients (<=0.32) set the nowait flag to false on the queue.delete method and
then incorrectly await regardless.}}
* In AMQPConnection_0_8.java {{_sendQueueDeleteOkRegardless}} defaults to
{{true}}. Is that on purpose?
* If {{Broker.CONNECTION_QUEUE_DELETE_NOWAIT_VERSION_REGEXP}} is not set it
defaults to the empty string which will always match. I guess this is not
desired. Maybe a regex that never matches would be more appropriate. [This
stackoverflow answer|http://stackoverflow.com/a/1845097] suggests {{\A(?!x)x}}.
The rest looks good to me!
> Java client 0-8..0-91 sends queue.delete with nowait true but then awaits a
> reply
> ---------------------------------------------------------------------------------
>
> Key: QPID-6744
> URL: https://issues.apache.org/jira/browse/QPID-6744
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.18, 0.22, 0.32
> Reporter: Keith Wall
> Assignee: Lorenz Quack
> Labels: rabbitmq
>
> The Java Client sends AMQP queue.delete with {{nowait}} hard-coded true, but
> then awaits a queue.delete-ok reply anyway. This defect is transparent with
> the Java Broker since the Broker sends the queue.delete-ok regardless of the
> setting of the nowait flag.
> This defect shows up when inter-operating against the RabbitMQ, which
> respects the {{nowait}} flag.
> This behaviour is longstanding.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
