[ https://issues.apache.org/jira/browse/DISPATCH-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965445#comment-14965445 ]
ASF GitHub Bot commented on DISPATCH-163: ----------------------------------------- Github user ted-ross commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/21#discussion_r42528135 --- Diff: src/server.c --- @@ -838,6 +840,13 @@ static void cxtr_try_open(void *context) return; } + // Set the sasl user name and password on the proton connection object. This has to be done before the call to qdpn_connector_transport() which + // binds the transport to the connection + if(config->sasl_username && config->sasl_password) { + pn_connection_set_user(ctx->pn_conn, config->sasl_username); + pn_connection_set_password(ctx->pn_conn, config->sasl_password); --- End diff -- I think you should treat the username and password independently. You shouldn't assume that there will always be both present. > Add username and password for authentication of connectors > ---------------------------------------------------------- > > Key: DISPATCH-163 > URL: https://issues.apache.org/jira/browse/DISPATCH-163 > Project: Qpid Dispatch > Issue Type: New Feature > Components: Container > Reporter: Ted Ross > Assignee: Ganesh Murthy > Fix For: 0.6 > > > Currently, connectors cannot use PLAIN authentication because there is no > configuration for username and password. This needs to be added. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org