----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39222/#review103405 -----------------------------------------------------------
examples/cpp/selected_recv.cpp (line 40) <https://reviews.apache.org/r/39222/#comment161464> Just to confirm: I agree with everyone else that dynamic should be a link_option, and the handler arg should come after the options. proton-c/bindings/cpp/include/proton/link.hpp (line 82) <https://reviews.apache.org/r/39222/#comment161465> Our users would appreciate it if we used nouns somewhere in these property names. Let's revisit. - Justin Ross On Oct. 16, 2015, 5:39 p.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39222/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 5:39 p.m.) > > > Review request for qpid, Alan Conway, Andrew Stitcher, and Justin Ross. > > > Bugs: PROTON-865 > https://issues.apache.org/jira/browse/PROTON-865 > > > Repository: qpid-proton-git > > > Description > ------- > > Link options, provided much like the Python client. > > Includes examples from Python for selector and browser. > > Additional link and terminus properties were added as required. > > The source can also be viewed in branch "linkoptions" on > https://github.com/cliffjansen/qpid-proton/ > > > Diffs > ----- > > examples/cpp/CMakeLists.txt 34edb83 > examples/cpp/queue_browser.cpp PRE-CREATION > examples/cpp/selected_recv.cpp PRE-CREATION > proton-c/bindings/cpp/CMakeLists.txt 45e47b2 > proton-c/bindings/cpp/include/proton/connection.hpp 08b6ad9 > proton-c/bindings/cpp/include/proton/link.hpp 88b5368 > proton-c/bindings/cpp/include/proton/link_options.hpp PRE-CREATION > proton-c/bindings/cpp/include/proton/terminus.hpp 4bb9651 > proton-c/bindings/cpp/src/connection.cpp 84c79a6 > proton-c/bindings/cpp/src/link.cpp 12c8790 > proton-c/bindings/cpp/src/link_options.cpp PRE-CREATION > proton-c/bindings/cpp/src/terminus.cpp 2c960d6 > > Diff: https://reviews.apache.org/r/39222/diff/ > > > Testing > ------- > > Linux. Checked attach frames compared to Python. > > > Thanks, > > Cliff Jansen > >
