Great, all seems to work as before now. Thanks for the fix.
Regards Jakub On Fri, Oct 23, 2015 at 6:03 PM, Timothy Bish <[email protected]> wrote: > Tracked down the reason for the change and added a fix and some tests to > master, should be sorted now if you want to test it out again. > > On 10/23/2015 09:57 AM, Jakub Scholz wrote: > > I prepared a simple test: > > https://gist.github.com/scholzj/45dfc385a06c7ac971a8 > > > > You should be able to copy it to the qpid-jms-interop-tests and run > against > > the ActiveMQ broker. It is passing in 0.6.0 and failing in master > (0.7.0). > > > > Basically, in 0.7.0 the receiver2.close() doesn't close the reciever. As > a > > result it aquires again the message which cannot be received by > receiver3. > > In 0.6.0, the receiver2.close() really closed the receiver and as a > result > > it can be read by receiver3. > > > > Thanks > > JAkub > > > > On Thu, Oct 22, 2015 at 5:15 PM, Timothy Bish <[email protected]> > wrote: > > > >> On 10/22/2015 11:14 AM, Jakub Scholz wrote: > >>> On Thu, Oct 22, 2015 at 4:59 PM, Timothy Bish <[email protected]> > >> wrote: > >>>> If the receiver had transactional > >>>> work then it would remain open until the session closed, otherwise if > >>>> should close down immediately. > >>>> > >>> Ah, ok. In my case, the receiver received some messages, but the > >>> transaction was rolled back. There should be no outstanding messages > >> which > >>> were received in my code using the receive() method or using a > listener. > >>> > >>> So it sounds like it works as it should, only differently compared to > >> 0.6.0. > >>> Thanks & Regards > >>> Jakub > >>> > >> If you want to write a small test case I would be happy to validate that > >> it is working as intended, things are in flux in the TX bits right now > >> so good to check that nothing gets broken. > >> > >> -- > >> Tim Bish > >> Sr Software Engineer | RedHat Inc. > >> [email protected] | www.redhat.com > >> twitter: @tabish121 > >> blog: http://timbish.blogspot.com/ > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > > -- > Tim Bish > Sr Software Engineer | RedHat Inc. > [email protected] | www.redhat.com > twitter: @tabish121 > blog: http://timbish.blogspot.com/ > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
